fix: remove the unused tab-expand-max variable #11001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncoden
approved these changes
Mar 2, 2018
There was a problem hiding this comment.
$tab-expand-maxis introduced in the initial Tabs commit (acb151a, @zurbrandon) and was never used. It is safe to remove.
-- #8484 (comment)
LGTM 👍
| @@ -800,7 +800,6 @@ $tab-active-color: $primary-color; | |||
| $tab-item-font-size: rem-calc(12); | |||
| $tab-item-background-hover: $white; | |||
| $tab-item-padding: 1.25rem 1.5rem; | |||
| $tab-expand-max: 6; | |||
There was a problem hiding this comment.
No need to remove variables in settings/_settings.scss as it is automatically generated ;)
There was a problem hiding this comment.
Mh, in the src / scss directory? Should I revert this file change then?
ncoden
pushed a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 16, 2018
…ed-variable-expand-max-8484 for v6.5.0 ff97871 fix: remove the unused tab-expand-max variable Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the unused
$tab-expand-maxvariable.Closes #8484