chore: move from bower to npm #11073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncoden
reviewed
Mar 18, 2018
|
I think so. I did not find any |
ncoden
approved these changes
Mar 18, 2018
ncoden
pushed a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 16, 2018
…r-to-npm for v6.5.0 e7752a4 chore: move from bower to npm Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 25, 2018
Bower dependencies in `bower.json` were removed in foundation#11073 in the migration from Bower to npm. These dependencies should not have been removed as the Bower package still require `jquery` and `what-input`. Someone installing `foundation-sites` with bower should still have these packages included. We simply don't use Bower anymore in development mode and don't promote its usage in the documentation. Removing `bower install` commands was sufficiant for this migration and Bower dependencies in `bower.json` were unrelated. See foundation#11073
12 tasks
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 25, 2018
Bower dependencies in `bower.json` were removed in foundation#11073 in the migration from Bower to npm. These dependencies should not have been removed as the Bower package still require `jquery` and `what-input`. Someone installing `foundation-sites` with bower should still have these packages included. We simply don't use Bower anymore in development mode and don't promote its usage in the documentation. Removing `bower install` commands was sufficiant for this migration and Bower dependencies in `bower.json` were unrelated. See foundation#11073
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.