Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated mixins #11083

Merged
merged 2 commits into from Mar 26, 2018
Merged

chore: remove deprecated mixins #11083

merged 2 commits into from Mar 26, 2018

Conversation

DanielRuf
Copy link
Contributor

$responsive-embed-ratio, foundation-flex-video and flex-video are deprecated and should be already removed in 6.4.

ncoden
ncoden reviewed Mar 22, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you can also remove grid-column-uncollapse and grid-col-uncollapse. I added their deprecation warnings 2 years ago 😢.

@DanielRuf
Copy link
Contributor Author

Ok, will do so later. In this and change the title or in a separate PR?

@ncoden
Copy link
Contributor

ncoden commented Mar 22, 2018

It's simpler and more appropriate there to change the title: that's the same type of change and for the same reasons.

@DanielRuf
Copy link
Contributor Author

Sorry, forgot to do it at work.

@DanielRuf DanielRuf changed the title chore: remove deprecated responsive embed mixins chore: remove deprecated mixins Mar 24, 2018
@ncoden ncoden added this to the 6.5.0 milestone Mar 24, 2018
@DanielRuf
Copy link
Contributor Author

https://travis-ci.org/zurb/foundation-sites/jobs/357814088#L2987

Did someone change the access to Browserstack? Currently the tests fail due to this.

@ncoden
Copy link
Contributor

ncoden commented Mar 24, 2018

@DanielRuf The access key changed. I'm waiting for @rafibomb to get access to a new key, and I'm working on removing the key from the repo.

@ncoden
Copy link
Contributor

ncoden commented Mar 24, 2018

@DanielRuf I'm priotizing bug fixs and tests for v6.5.0, keeping new features for later. Could you please take a look at the last PRs without reviews ?

@ncoden ncoden merged commit 6c5a89a into foundation:develop Mar 26, 2018
@DanielRuf DanielRuf deleted the chore/remove-deprecated-responsive-embed-mixins branch March 26, 2018 19:13
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@DanielRuf @ncoden
Use pull request foundation#11083 from DanielRuf/chore/remove-depreca…
8a06765 
…ted-responsive-embed-mixins for v6.5.0

2c459d1 chore: remove deprecated responsive embed mixins
4abaf7a chore: remove deprecated grid-column-uncollapse and grid-col-uncollapse mixins

Co-Authored-By: Daniel Ruf <daniel@daniel-ruf.de>
Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoden ncoden ncoden approved these changes

Assignees
No one assigned
Labels
Sass Mixins scss
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielRuf @ncoden