fix: always use absolute positioning to prevent jumping Orbit slider #11107
Conversation
js/foundation.orbit.js
Outdated
| this.options[`animInFrom${dirIn}`], | ||
| function(){ | ||
| $newSlide.css({'position': 'relative', 'display': 'block'}) | ||
| .attr('aria-live', 'polite'); | ||
| $newSlide.attr('aria-live', 'polite'); |
There was a problem hiding this comment.
Slides display are set to hidden when motion-ui is not used.
We should keep 'display': 'block';
There was a problem hiding this comment.
Ah, just the block property?
There was a problem hiding this comment.
Yeah, and remove 'position': 'relative' from line 153. But make some tests (with and without motionUI / mui classes), I'm not sure.
|
Ok, will do some more tests later. |
|
@DanielRuf Tell me when you done your tests or if I should take care of them 😉 |
Some help is really appreciated and would be great. |
There was a problem hiding this comment.
Yeah, and remove 'position': 'relative' from line 153. But make some tests (with and without motionUI / mui classes), I'm not sure.
I found a bug before figuring out that 'position': 'relative' was not removed. I took care of this.
7daaba5 fix: remove position reset of Orbit slides preventing the "full-absolute" new behavior
All Orbit slides should always have an
absolutepositioning to prevent jumping Orbit slider (see #11107). The'position': 'relative'reset is no longer necessary here and break the Orbit behavior as inline styles overrides.orbit-slideclass styles.
I made some tests and everything seems to work 👍
…tioning-jump-11082 for v6.5.0 dbdae96 fix: always use absolute positioning to prevent jumping Orbit slider cf80a48 fix: render slide as block element 7daaba5 fix: remove position reset of Orbit slides preventing the "full-absolute" new behavior Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr> Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Before and after a slide is animted its position attribute is changed between
absoluteandrelativewhich can produce a jump of the element after a slide change.Closes #11082