tests: use husky to run tests before commits and pushes

[DanielRuf]

We should force to run npm test on each commit / push.

Should we use precommit and prepush or just one of both?

Closes #11042

The rest of it will be probably covered in future code quality related PRs for all devs.

[DanielRuf]

PS: I did not add the changed package-lock.json file but we may have to update it.

Also see #11046

[ncoden]

That's nice 🐶

Because a common rule in Git is that the code should always run, I guess we can use precommit. And prepush does not harm :).

[ncoden]

I seen #11046. I think I'll take care of adding it after manually upgraded all our dependencies to prepare v6.5. There's no benefit in adding it if we're not already up-to-date.

[ncoden]

I just noticed this PR is number #11111 😄

[ncoden]

chore: add message for about Husky at precommit & prepush

[DanielRuf]

This will probably not work on most Windows machines @ncoden, why not ouput it directly with Node.js?

[ncoden]

Ah, yeah...

[ncoden]

Actually, what would not run on Windows ? The whole NPM environement with npm scripts is based on bash, and Windows users are invited to set by themselve the program to use for commands.

Also, using JS scripts does not resolve the compatibility issue as we have to run npm test at the middle on the script, which is far more complicated to do in JS than in Bash..

[DanielRuf]

bash can not be used in cmd and git and npm are globally available on the path but bash isn't, just in the extra environment.

Will test later on my machine but it will not run afaik.

[DanielRuf]

$ npm run precommit

> foundation-sites@6.4.3 precommit C:\Users\Daniel\GITHUB\foundation-sites
> ./script/husky-precommit

Der Befehl "." ist entweder falsch geschrieben oder
konnte nicht gefunden werden.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! foundation-sites@6.4.3 precommit: `./script/husky-precommit`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the foundation-sites@6.4.3 precommit script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\Daniel\AppData\Roaming\npm-cache\_logs\2018-04-01T19_34_49_592Z-debug.log

I'll provide a working solution.

[DanielRuf]

There you go =)

[ncoden]

Thanks 👍

[DanielRuf]

Oops, small copy paste error =/
Forgot to rename it in package.json.

[ncoden]

Fixed :)

[DanielRuf]

Actually had it prepared here but not commited anymore.

[ncoden]

Also, the Sass tests output is not colored anymore. Do you have an idea of what is causing this ?

[DanielRuf]

I guess this is because it is running in another context now and the color support is disabled there. I'm checking if we can use another solution here.

[DanielRuf]

Should be colored again now.

[DanielRuf]

Forcing the colors mode now by default. For sass-lint we might move to stylelint somewhere in the future.

[ncoden]

94b956b fix: always use color mode
02d08db Merge branch 'tests/use-husky' of github.com:danielruf/foundation-sit…
202576f fix: always use color mode

Rebase instead of merging when your commits are not pushed yet. git pull [...] --rebase

[DanielRuf]

I guesset I should set the setting to rebase by default here too.

Should I squash merge or rebase now and push force the last 3 commits as one?

[ncoden]

360380d chore: remove code test output

Please always put the context in your commits. "chore: remove code test output in husky scripts" 😉

[ncoden]

Should I squash merge or rebase now and push force the last 3 commits as one?

Since no reviews are based on these commits, yes please do shash them ;).

[ncoden]

Side note: I really love this emoji 🐶

[ncoden]

I guess it's good to go 👍