fix: use more permissive URL pattern for Abide #9180 #11116
Merged
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: the new RegExp is close to an "Standard URL validation" and allow a lot of valid URLs that may have to be forbidden on the end website (intrants, local domains, utf8 & unicode characters...). For more restrictive RegExps, see https://mathiasbynens.be/demo/url-regex. Closes foundation#9180 From https://github.com/talyssonoc/CommonRegexJS/blob/e2901b9f57222bc14069dc8f0598d5f412555411/lib/commonregex.js#L76
DanielRuf
reviewed
Apr 2, 2018
docs/pages/abide.md
Outdated
| @@ -321,8 +321,13 @@ cvv : /^([0-9]){3,4}$/, | |||
|
|
|||
| // http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#valid-e-mail-address | |||
| email : /^[a-zA-Z0-9.!#$%&'*+\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)+$/, | |||
| }[a-zA-Z0-9])?)+$/, | |||
There was a problem hiding this comment.
Is this line added by accident?
DanielRuf
reviewed
Apr 2, 2018
docs/pages/abide.md
Outdated
| // From CommonRegexJS (@talyssonoc) | ||
| // https://github.com/talyssonoc/CommonRegexJS/blob/e2901b9f57222bc14069dc8f0598d5f412555411/lib/commonregex.js#L76 | ||
| // For more restrictive URL Regexs, see https://mathiasbynens.be/demo/url-regex. | ||
| url: /^((?:(https?|ftp|file|ssh):\/\/|www\d{0,3}[.]|[a-z0-9.\-]+[.][a-z]{2,4}\/)(?:[^\s()<>]+|\((?:[^\s()<>]+|(?:\([^\s()<>]+\)))*\))+(?:\((?:[^\s()<>]+|(?:\([^\s()<>]+\)))*\)|[^\s`!()\[\]{};:\'".,<>?\xab\xbb\u201c\u201d\u2018\u2019]))$/, |
There was a problem hiding this comment.
What about sftp and ftps? Or should these not be covered here?
There was a problem hiding this comment.
These were not accepted before. but we can add them
|
Rest looks good so far accoding to some regex tests. |
DanielRuf
approved these changes
Apr 3, 2018
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 16, 2018
…l-regexp-9180 for v6.5.0 724545c fix: use more permissive URL pattern for Abide foundation#9180 01dde90 docs: remove line added by accident in Abide regex docs db8d81f feat: add SFTP & FTPS to Abide valid urls protocols Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a more permissive URL regex in Abide to allow all escaped characters and various others valid URLs.
Changes:
Note: the new RegExp is close to an "Standard URL validation" and allow a lot of valid URLs that may have to be forbidden on the end website (intrants, local domains, utf8 & unicode characters...).
For more restrictive RegExps, see https://mathiasbynens.be/demo/url-regex.
Closes #9180