Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in-canvas-for-x width:auto instead of width:inherit #11141

Merged
merged 2 commits into from
Apr 13, 2018
Merged

in-canvas-for-x width:auto instead of width:inherit #11141

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d4734a
in-canvas-for-x width:auto instead of width:inherit
RvWensen Apr 6, 2018
ca18489
fix: reset all OffCanvas properties when in in-canvas mode
ncoden Apr 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scss/components/_off-canvas.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ $breakpoint: small
height: auto;
position: static;
background: inherit;
width: inherit;
width: auto;
Copy link
Contributor

@ncoden ncoden Apr 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense for width: auto, but @SassNinja was there any reasons for using inherit in the first place for properties that does not inherit their value by default (background, overflow, transition...) ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

poke @SassNinja

Copy link
Contributor

@ncoden ncoden Apr 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done some research. The incanvas feature always used inherit, without explicit reasons given. Most font properties should inherit but not background, width, overflow, transition as this is not their default value. I'll replace all of them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ncoden the in-canvas is supposed to just revert the off-canvas styles. Seems I was overusing the inherit a bit ;)
You're replacements of the properties in talk look good to me 👍

overflow: inherit;
transition: inherit;

Expand Down