Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use npm ci #11174

Merged
merged 1 commit into from Apr 14, 2018
Merged

build: use npm ci #11174

merged 1 commit into from Apr 14, 2018

Conversation

DanielRuf
Copy link
Contributor

npm ci can be faster and is meant for CI. This PR is meant for evaluating the new ci command and testig the performance and compare the logs of Travis CI.

https://docs.npmjs.com/cli/ci
http://blog.npmjs.org/post/171556855892/introducing-npm-ci-for-faster-more-reliable

@ncoden
Copy link
Contributor

ncoden commented Apr 14, 2018 •
edited
Loading

Performances:

  • npm install: 113s
    screen shot 2018-04-14 at 19 40 30

  • npm ci: 58s (95% faster)
    screen shot 2018-04-14 at 19 40 10

ncoden
ncoden approved these changes Apr 14, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

npm@lastest is required there to enforce older node versions to use the NPM latest version. It should always be compatible as NPM supports all node LTS versions.

And for npm ci itself, well it's better, faster, stronger ;)

@ncoden ncoden merged commit ade7207 into foundation:develop Apr 14, 2018
@DanielRuf DanielRuf deleted the build/npm-ci branch April 14, 2018 21:55
@ncoden ncoden added this to the 6.5.0 milestone Apr 24, 2018
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@DanielRuf @ncoden
Use pull request foundation#11174 from DanielRuf/build/npm-ci for v6.5.0
25ff556 
9242a2c build: use npm ci

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoden ncoden ncoden approved these changes

Assignees
No one assigned
Labels
🚚 build
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielRuf @ncoden