Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Edge to flexbox supported browsers #11240

Merged

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented May 6, 2018

Description

Added Edge to flexbox supported browsers (info from caniuse.com) and small SPaG fix

Opened from #11239 (@danielrhodeswarp). I rebased commits and added the requested changes.

Motivation and Context

Completes the info and fixes a SPaG issue

Screenshots (if appropriate):

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or support/*).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • All new and existing tests passed.

danielrhodeswarp and others added 2 commits May 6, 2018 19:18
Added Edge to flexbox supported browsers (info from caniuse.com) and small SPaG fix
@ncoden
Copy link
Contributor Author

ncoden commented May 7, 2018

Poke @DanielRuf for review :)

Yeah, this PR is really simply but at least one review is required to merge!

@ncoden ncoden merged commit ef4a3d3 into foundation:develop May 15, 2018
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
…ibility-table for v6.5.0

6a8b76d docs: add Edge to flexbox supported browsers
420a1a5 docs: merge IE and Edge in flexbox supported browsers

Co-Authored-By: Nicolas Coden <nicolas@ncoden.fr>
Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants