Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add multiple issue templates #11246

Merged
merged 4 commits into from
May 11, 2018
Merged

chore: add multiple issue templates #11246

merged 4 commits into from
May 11, 2018

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented May 7, 2018 •
edited
Loading

Add the following issue templates:

  • 🐛 Bug Report
            Something is broken or doesn't work as expected
  • ✨ Feature Request
            Something is missing or could be improved
  • 📖 Documentation
            Typo mistakes, gaps or inconsistencies in docs or website
  • 💻 Maintainance
            Tests, dependencies, workflow...

Closes #11241

@ncoden ncoden mentioned this pull request May 7, 2018
Closed
@ncoden ncoden requested a review from DanielRuf May 7, 2018 21:53
@ncoden
Copy link
Contributor Author

ncoden commented May 8, 2018

Poke @DanielRuf for review :)

DanielRuf
DanielRuf approved these changes May 8, 2018
View reviewed changes
.github/ISSUE_TEMPLATE/1-bug-report.md Outdated
## What should happen?


## What happends instead?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happends => happens

.github/ISSUE_TEMPLATE/2-feature-request.md Outdated
<!--- What you want to be added or improved and how you would use it? -->

## Why is it important?
<!--- Why would this feature benefits to everyone? What is the current -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

benefits to => benefit

.github/ISSUE_TEMPLATE/4-maintainance.md Outdated
<!--- Please fill the following template -->
<!--- Your issue may be ignored otherwise -->
<!--- --------------------------------------------------------------------- -->
<!--- Only submit maintainance issue here. For help or questions to the. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue => issues

DanielRuf
DanielRuf suggested changes May 8, 2018
View reviewed changes
Copy link
Contributor

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small typos.

@ncoden
Copy link
Contributor Author

ncoden commented May 8, 2018

Thank you for the review.

@ncoden
Copy link
Contributor Author

ncoden commented May 9, 2018

@DanielRuf Fixed

@ncoden
Copy link
Contributor Author

ncoden commented May 11, 2018

poke @DanielRuf

@ncoden ncoden merged commit 8e14500 into develop May 11, 2018
@DanielRuf DanielRuf deleted the chore/multiple-issue-templates-11241 branch May 11, 2018 21:38
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@ncoden
Use pull request foundation#11246 from zurb/chore/multiple-issue-temp…
37c5c64 
…lates-11241 for v6.5.0

73865b8 chore: add multiple issue templates
f4195bd chore: ensure GitHub issue templates are in the right order
0537824 chore: add Documentation GitHub issue template
08d58b8 chore: fix typo in GitHub templates

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf DanielRuf approved these changes

Assignees
No one assigned
Labels
💻 maintenance 💻 workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncoden @DanielRuf