Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: spelling and grammar corrections #11249

Merged
merged 1 commit into from
May 11, 2018
Merged

docs: spelling and grammar corrections #11249

merged 1 commit into from
May 11, 2018

Conversation

datatypevoid
Copy link

@datatypevoid datatypevoid commented May 11, 2018 •
edited by ncoden
Loading

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or support/*).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • All new and existing tests passed.

@DanielRuf
Copy link
Contributor

Hi,

congrats to your first contribution to Foundation Sites 🎉

@DanielRuf DanielRuf self-requested a review May 11, 2018 11:22
DanielRuf
DanielRuf approved these changes May 11, 2018
View reviewed changes
Copy link
Contributor

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@DanielRuf
Copy link
Contributor

DanielRuf commented May 11, 2018 •
edited
Loading

Please tick the checkboxes that apply =)

@ncoden ncoden changed the title chore: spelling and grammar corrections docs: spelling and grammar corrections May 11, 2018
ncoden
ncoden approved these changes May 11, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @datatypevoid. LGTM.

As your commits only fixes spelling mistakes in documentation, your commits should be prefixed by docs: .

Could you please squash them into a single commit ?

@datatypevoid
Copy link
Author

Yeah let me pull it to my box real quick.

@ncoden
Copy link
Contributor

ncoden commented May 11, 2018

Thank you @datatypevoid. Merging.

@ncoden ncoden merged commit 70f6410 into foundation:develop May 11, 2018
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@ncoden
Use pull request foundation#11249 from datatypevoid/develop for v6.5.0
f403ddf 
1f0f9a6 docs: spelling and grammar corrections

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoden ncoden ncoden approved these changes

@DanielRuf DanielRuf DanielRuf approved these changes

Assignees
No one assigned
Labels
📖 documentation scss
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datatypevoid @DanielRuf @ncoden