Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent to initialize Triggers twice before window is loaded #11258

Merged

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented May 13, 2018

Description

Check if Triggers is already initialized just before it should be initialized, once the window is loaded.

Motivation and Context

For the following code:

...
Triggers.init($, Foundation);
Triggers.init($, Foundation);

Triggers will be initialized twice when the window will load.

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or support/*).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • All new and existing tests passed.

Changes:
* check if Triggers is already initialized just before it should be initialized, once the window is loaded.
@ncoden ncoden merged commit 50fa149 into foundation:develop May 15, 2018
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
…ils-to-load-twice for v6.5.0

4419192 fix: prevent to initialize Triggers twice before window is loaded

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants