Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix clashing IDs in form checkboxes #11262

Merged
merged 1 commit into from
May 14, 2018

Conversation

brianshano
Copy link
Contributor

@brianshano brianshano commented May 14, 2018

Description

Checkbox IDs in the "Forms" component are the same as in "Abide" and clashing with each other.
I have changed the IDs in "Forms" so they are distinct

Motivation and Context

If a user clicks the checkbox label "Blue" in "Forms" component it triggers the checkbox in "Abide" which is incorrect and confusing.

Screenshots (if appropriate):

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or support/*).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • All new and existing tests passed.

Checkbox IDs in the "Forms" component are the same as in "Abide" and clashing with each other. 
I have changed the IDs in "Forms" so they are distinct
@ncoden ncoden changed the title Fix: Docs: clashing IDs in form checkboxes docs: fix clashing IDs in form checkboxes May 14, 2018
@DanielRuf
Copy link
Contributor

DanielRuf commented May 14, 2018

Hi @brianshano, congrats to your first contribution to foundation-sites. 🎉

Please use the develop branch for new PRs (I'll take care of it).

@DanielRuf DanielRuf changed the base branch from master to develop May 14, 2018 10:27
@DanielRuf DanielRuf requested a review from ncoden May 14, 2018 10:28
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ncoden ncoden merged commit 57596e6 into foundation:develop May 14, 2018
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
d75d801 Fix: Docs: clashing IDs in form checkboxes

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants