Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forms.md #11283

Merged
merged 1 commit into from
May 20, 2018
Merged

Update forms.md #11283

merged 1 commit into from
May 20, 2018

Conversation

adamklepacz
Copy link
Contributor

@adamklepacz adamklepacz commented May 20, 2018

I have changed classes in #### Checkboxes and Radio Buttons cause in yours HTML EXAMPLE third checkbox was collapsing to the next line. That may was not understandable for some users.
Now it displays proper

Description

I have changed classes in #### Checkboxes and Radio Buttons cause in yours HTML EXAMPLE third checkbox was collapsing to the next line.

  • Closes

Motivation and Context

Change is about better user experience. Third checkbox was collapsing to the next line so it may was not understandable to some users.

Screenshots (if appropriate):

https://cdn3.imggmi.com/uploads/2018/5/20/0d0169ab644d95fe8dfe3e904d97f86b-full.png - after changes
https://cdn3.imggmi.com/uploads/2018/5/20/377786353be7cb3150513c91f3d83972-full.png - before changes

Types of changes

Change of classes inside HTML example.

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • [x ] I have read and follow the CONTRIBUTING document.
  • [x ] There are no other pull request similar to this one.
  • [x ] The pull request title is descriptive.
  • [x ] The template is fully and correctly filled.
  • [x ] The pull request targets the right branch (develop or support/*).
  • [x ] My commits are correctly titled and contain all relevant information.
  • [ x] My code follows the code style of this project.
  • [x ] I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • [x ] All new and existing tests passed.

I have changed classes in #### Checkboxes and Radio Buttons cause in yours HTML EXAMPLE third checkbox was collapsing to the next line. 
Now it displays proper
@ncoden ncoden changed the base branch from master to develop May 20, 2018 19:43
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adamklepacz Please note that all pull requests must be opened on develop now, even for documentation changes. I took care of this.

See CONTRIBUTING.md

@ncoden ncoden merged commit d56b2f9 into foundation:develop May 20, 2018
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
94171dd Update forms.md

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants