Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update foundation-docs for the "ClipboardJS" patch #11292

Merged
merged 1 commit into from
May 24, 2018

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented May 21, 2018

Description

Update foundation-docs to latest version 7a978ff

Included changes (from 60e2428 to 7a978ff):

  • 1489588 style: add newline
  • 5184de6 style: remove extraneous space
  • aaa25b0 fix: increase z-index of topbar
  • 65242d8 chore: update lockfile
  • 477baf9 tests: use npm ci
  • b323354 fix: migrate to the new ClipboardJS instantiation to resolve conflict with window.Clipboard
  • 9331594 fix: add namespace to type class in Sass reference table

Motivation and Context

The current foundation-sites version rely on b323354 which renamed Clipboard to ClipboardJS.

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or support/*).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • All new and existing tests passed.

Required because of b323354 that renamed Clipboard to ClipboardJS

Included changes:
* 1489588 style: add newline
* 5184de6 style: remove extraneous space
* aaa25b0 fix: increase z-index of topbar
* 65242d8 chore: update lockfile
* 477baf9 tests: use npm ci
* b323354 fix: migrate to the new ClipboardJS instantiation to resolve conflict with window.Clipboard
* 9331594 fix: add namespace to type class in Sass reference table
@ncoden ncoden merged commit 61dbe4f into foundation:develop May 24, 2018
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
…-docs for v6.5.0

7c45c95 chore: update foundation-docs

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants