Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Babel to v7 #11317

Merged
merged 4 commits into from
Jun 4, 2018
Merged

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented Jun 2, 2018

Description

Update Babel and all related packages to v7 beta.

Changes:

Updated packages

  • babel-core (^6.26.0) -> @babel/core (7.0.0-beta.44)
  • babel-preset-env (^1.6.1) -> @babel/preset-env (7.0.0-beta.44)
  • babel-loader (^7.1.2) -> babel-loader (^8.0.0-beta.0)
  • gulp-babel (^7.0.1) -> gulp-babel (8.0.0-beta.2)

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or support/*).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • All new and existing tests passed.

⚠️ Require

ncoden added 3 commits June 2, 2018 20:43
Foundation now require the `env` babel preset with a browserlist, but browserify config is oudated and still uses the `es2015` preset.

Changes:
* use the `env` babel prese for browserify transformation instead of `es2015`
Note: browserlist config is kept in ".babelrc" because browserlist external config is not supported by Babel < 7. See https://github.com/browserslist/browserslist
Update update and related packages to v7 beta.

Changes:
* Migrate to `@babel/*` packages
* Use `@babel/preset-env` instead of `env` preset
* Remove unecessary browserlist config in `.babelrc` config
* Update Yarn lockfiles
Export is no longer ignored for undefined variables in babel-core@7.
@ncoden ncoden merged commit 760213e into foundation:develop Jun 4, 2018
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
…for v6.5.0

4174473 fix: use the env babel preset for browserify transformation
07348e7 refactor: move all browserlist configs to .browserslistrc
1b09e3d chore: update Babel to v7
4a42d2a fix: add missing Foundation import in Touch entry

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants