fix: remove $-zf-size from non-responsive XY Grid classes generation #11361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`$-zf-size` is only set within breakpoints. Breakpoints are not expected to be used around the `xy-vertical-grid-classes()` mixin. Note: a more appropriate fix would be to rely on the `xy-cell()` mixin instead of `xy-cell-static()` to fully support explicit/implicit/null breakpoint option. However this may introduce breaking changes, so this will be kept for v6.6.0. [This fix is compatible with v6.5]
|
Hey @ncoden, tested your changes, works fine now! Thanks. |
|
Thank you @marvinhuebner for the review. |
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jul 6, 2018
…side-of-breakpoint for v6.5.0 a4cac3f fix: remove $-zf-size from non-responsive XY Grid classes generation Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jul 8, 2018
…side-of-breakpoint for v6.5.0 a4cac3f fix: remove $-zf-size from non-responsive XY Grid classes generation Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolve and issue with
$-zf-sizebeing used outside of a breakpoint and without fallback, leading to various warnings and discreet side-effects.$-zf-sizeis only set within breakpoints. Breakpoints are not expected to be used for thexy-vertical-grid-classes()mixin.[This fix is compatible with v6.5]
Motivation and Context
Note: a more appropriate fix would be to rely on the
xy-cell()mixin instead ofxy-cell-static()to fully support explicit/implicit/null breakpoint option. However this may introduce breaking changes, so this will be kept for v6.6.0.Screenshots (if appropriate):
Types of changes
functionality to change)
Checklist (all required):
developorsupport/*).I have updated the documentation accordingly to my changes (if relevant).I have added tests to cover my changes (if relevant).