Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: follow relative and absolute links in SmoothScroll #11506 #11510

Merged
merged 1 commit into from
Sep 21, 2018
Merged

fix: follow relative and absolute links in SmoothScroll #11506 #11510

merged 1 commit into from
Sep 21, 2018

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented Sep 20, 2018 •
edited
Loading

Description

Do not prevent relative and absolute links to be followed when used with SmoothScroll. As a "SmoothScroll" only makes sense for internal anchors, it should not affect or break other types of links.

Closes: #11506

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@ncoden ncoden mentioned this pull request Sep 20, 2018
Closed
3 tasks
@ncoden ncoden added this to the 6.5.0 milestone Sep 20, 2018
@ncoden ncoden merged commit b14d6ee into foundation:develop Sep 21, 2018
ncoden added a commit that referenced this pull request Sep 25, 2018
@ncoden
Use pull request #11510 from ncoden/fix/smooth-scroll-absolute-links-…
f5afa1d 
…11506 for v6.5.0

140abba fix: follow relative and absolute links in SmoothScroll #11506

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden ncoden mentioned this pull request Sep 25, 2018
Merged
10 tasks
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug fix Smooth Scroll
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

[Smooth Scroll] Prevents navigation to relative or absolute urls
1 participant
@ncoden