fix: clean SmoothScroll listeners on destroy #11519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanielRuf I found this bug while searching for the forgotten typo mistake you pointed out at #11516. I kept the "points to" formulation for the reasons given at #11516 (comment). |
ncoden
force-pushed
the
fix/clean-smoothscroll-events-on-destroy
branch
from
7067f9f to
65c26b1
Compare
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Sep 29, 2018
…events-on-destroy for v6.5.0 7d717bf refactor: move SmoothScroll to ES6+ and fix linting issues fd14999 refactor: move SmoothScroll click event handling to its own function e0fbd09 fix: clean SmoothScroll events when destroyed 65c26b1 docs: fix typo in SmoothScroll click handler Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
SmoothScrollclick event listeners (to scroll the the pointed event) on destroy.Others changes:
SmoothScrollSmoothScrollSmoothScrollclick event handling to its own methodSmoothScrollclick handlerRelated to #11516
Types of changes
Checklist
developordevelop-v...).I have updated the documentation accordingly to my changes (if relevant).I have added tests to cover my changes (if relevant).