Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Triggers as Magellan dependency #11645 #11654

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

denisahac
Copy link
Contributor

@denisahac denisahac commented Jan 16, 2019

Description

Fix for Magellan .is-active class not being applied when use as an individual module.

  • Closes

#11645

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

@denisahac
Copy link
Contributor Author

@DanielRuf @ncoden this is the new pull request for #11645 and added Triggers.init($) on component initialization.

Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @denisahac, thank you for your pull request.
LGTM 👍. Compatible with 6.5.

@ncoden ncoden mentioned this pull request Jan 16, 2019
5 tasks
@ncoden ncoden added this to the 6.5.2 milestone Jan 16, 2019
@ncoden ncoden merged commit 5750fa6 into foundation:develop Jan 16, 2019
@joeworkman
Copy link
Member

This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there:

https://foundation.discourse.group/t/foundation-for-sites-v6-6-0-is-here-farout/30/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants