Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11821 give deeplink-smudge a offset to prevent scrolling behind a fixed menu at top of page. #11959

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

Lefthandmedia
Copy link
Contributor

Description

...When using using deeplink smudge on a accordeon the requested anchor scrolls to the top of the page. If there is a sticky element at the top of the page (like a sticky navigation) the requested anchor is hidden when it scrolls to the top of the page. To prevent this you can add a data-attribute data-deep-link-smudge-offset to give the scroll up animation an offset to prevent this.

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

…rolling behind a fixed menu at top of page.
Copy link
Contributor

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for your contribution to Foundation Sites

@Lefthandmedia
Copy link
Contributor Author

Travis needs to do its work better.
The command "curl -o- -L https://yarnpkg.com/install.sh | bash" failed and exited with 1 during .
has nothing to do with this PR

@joeworkman
Copy link
Member

This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there:

https://foundation.discourse.group/t/offset-data-deep-link-how-to/678/3

@joeworkman
Copy link
Member

This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there:

https://foundation.discourse.group/t/foundation-for-sites-6-6-2/1936/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

give deeplink-smudge a deeplink-offset to prevent scrolling behind a fixed menu at top of page.
3 participants