Add an ability to create custom components #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcandre
requested changes
Mar 2, 2020
| INTERIM_TH_TAG_REGEX = %r{(?<=\<|\<\/)#{Regexp.escape(INTERIM_TH_TAG)}} | ||
|
|
||
| DEFAULT_COMPONENTS = { | ||
| "button" => Inky::Components::Button, |
There was a problem hiding this comment.
Might as well be consistent and use ::Inky...
| self.components = DEFAULT_COMPONENTS | ||
| .merge(options[:components] || ::Inky.configuration.components) | ||
| .transform_values { |component_class| component_class.new(self) } | ||
| .with_indifferent_access |
There was a problem hiding this comment.
Best not use with_indifferent_access which is Rails-only (and controversial)
| def initialize(options = {}) | ||
| self.components = DEFAULT_COMPONENTS | ||
| .merge(options[:components] || ::Inky.configuration.components) | ||
| .transform_values { |component_class| component_class.new(self) } |
There was a problem hiding this comment.
transform_values is Ruby 2.4+ only; we support older rubies (I think). Would be easy to require 'backports/2.4.0/hash/transform_values' or change the code.
| @inky = inky | ||
| end | ||
|
|
||
| def _pass_through_attributes(elem) |
There was a problem hiding this comment.
I'm not sure why these methods started with _ (simili-private?) but if we are to move them we probably should use the standard conventions and remove the leading _. You can make them protected if you like, but I don't feel that would be necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.