ERB Template and Generator Fix #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #41. The problem here was that ERB's literal tag delimiters (
<%%) were removed from the template, causing thestylesheet_link_tagto be evaluated at the context of the InstallGenerator.Additionally, the install generator was reworked to accept a more intuitive format of arguments and options. Previously, a user would have to specify a layout name in order to be able to then pass in the templating language argument (e.g
rails g inky:install some_name slim).The new generator format is more consistent with how we pass options into
foundation-railsgem. Template type can now be specified without having to also provide a name:rails g inky:install --slim