Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: <spacer> no longer including extra attributes #135

Open
marcandre opened this issue Dec 6, 2021 · 0 comments
Open

Regression: <spacer> no longer including extra attributes #135

marcandre opened this issue Dec 6, 2021 · 0 comments

Comments

@marcandre
Copy link
Contributor

marcandre commented Dec 6, 2021

The <spacer> tag no longer includes extra attributes and they are entirely dropped:

Example:

<spacer class="some classes" foo="bar" size="42"/>
# 1.3.8 converts to:
<table foo="bar" class="classes some spacer">[...]
# 1.4.2 converts to:
<table class="classes some spacer">[...]

Note that other tags do include extra attributes.

(Noticed when running the inky-rb test suite)

@marcandre marcandre changed the title Regression: <spacer> no longer including extra attributes Regression: <spacer> and <button> no longer including extra attributes Dec 6, 2021
@marcandre marcandre changed the title Regression: <spacer> and <button> no longer including extra attributes Regression: <spacer> no longer including extra attributes Dec 6, 2021
marcandre added a commit to foundation/inky-rb that referenced this issue Dec 6, 2021
marcandre added a commit to foundation/inky-rb that referenced this issue Dec 6, 2021
marcandre added a commit to foundation/inky-rb that referenced this issue Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant