-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added data-attribute no-expander to <columns> to disable the .expander #29
Conversation
…r TH being added.
3 new test with no-expander on columns (case only empty Data-attribute no-expander, Data-attribute no-expander = false & Data-attribute no-expander = true)
We talked about doing something like this. Like the way you made it an attribute. Can you share a code example use case we can test against to make sure this PR solves it? |
This is the mail we made. (all names of the company cleared.) On windows outlook (live) mail the images went to 50%; With the addition:
Then it worked for 100% wide. |
Looking to pull this in for the next release. Here's the update: Just published the Foundation for Emails 2.1 release blog post and the release went out this morning! We also started a discussion on the future of Inky and what amazing integrations can be made. I'm sure you have some comments, questions, or ideas: http://foundation.zurb.com/forum/posts/39717-architecting-the-future-of-foundation-for-emails |
Added data-attribute no-expander to to disable the .expander.
Reason of adding:
To disable adding th.expander on a column when it has 12 size.
It breaks the full width images in the emails in MS outlook & MS live, setting the width of the cell 50%.
With this edit, you can disable the expander, by adding no-expander to
Example:
<columns large="12" small="12" no-expander>One</columns>
Results in:
`