apps: Remove ref to parent target apps if app target #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a target is produced by a container CI job then there is no need in having `target.custom.origUriApps` value in the target since `target.custom.uri` refers to a CI job that produced it. The `origUriApps` should be set only by the LmP target producer to refer to the most recent container CI job that produced apps inherited by a given LmP target. Signed-off-by: Mike Sul <mike.sul@foundries.io>
MrCry0
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a target is produced by a container CI job then there is no need in having
target.custom.origUriAppsvalue in the target sincetarget.custom.urirefers to a CI job that produced it. TheorigUriAppsshould be set only by the LmP target producer to refer to the most recent container CI job that produced apps inherited by a given LmP target.