helpers: repo_sync: don't use the operator && #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrCry0
reviewed
Nov 15, 2024
| @@ -76,16 +76,22 @@ function repo_sync { | |||
| fi | |||
| _repo_extra_args="" | |||
| for i in $(seq 4); do | |||
| run repo init $_repo_extra_args --repo-rev=v2.35 --no-clone-bundle -u $* ${REPO_INIT_OVERRIDES} && break | |||
| if run repo init $_repo_extra_args --repo-rev=v2.35 --no-clone-bundle -u $* ${REPO_INIT_OVERRIDES}; then | |||
There was a problem hiding this comment.
There is another way to always return true in such commands:
run repo init $_repo_extra_args --repo-rev=v2.35 --no-clone-bundle -u $* ${REPO_INIT_OVERRIDES} && break || true
@quaresmajose What do you think about this way?
There was a problem hiding this comment.
using if for this looks better to me and is more clean
doanac
approved these changes
Nov 15, 2024
MrCry0
approved these changes
Nov 15, 2024
igoropaniuk
approved these changes
Nov 16, 2024
Because we run the script with set -e Any return value other than 0 causes the process to abort. Using the operator && causes the script to abort because when the command fails there is no path to follow. If we use the if clause operator we solve the problem. Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
vanmaegima
approved these changes
Nov 18, 2024
angolini
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we run the script with set -e
Any return value other than 0 causes the process to abort.
Using the operator && causes the script to abort because when the command fails there is no path to follow.
If we use the if clause operator we solve the problem.