Apply suggestions from code review

Co-authored-by: vkhoroz <vkhoroz@users.noreply.github.com>
foundriesio · Oct 23, 2024 · cf83199 · cf83199
1 parent 1e6371a
commit cf83199
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/subcommands/targets/add.go b/subcommands/targets/add.go
@@ -29,7 +29,7 @@ func init() {
 		Short: "Compose and add Targets to Factory's TUF Targets metadata",
 		Run:   doAdd,
 		Long: `
-Compose new Targets out of the latest ones with the specified source tag via the command arguments—either OSTree commit hashes or App URIs.
+Compose new Targets out of the latest ones with the specified source tag via the command arguments — either OSTree commit hashes or App URIs.
 
 fioctl targets add --type <ostree | app> --tags <comma,separate,list of Target tags> --src-tag <source Target tag> [--targets-creator <something about Targets originator>]\ 
 	<hardware ID> <ostree commit hash> [<hardware ID> <ostree commit hash>]  (for ostree type)

diff --git a/subcommands/targets/tag.go b/subcommands/targets/tag.go
@@ -28,7 +28,7 @@ func init() {
   fioctl targets tag --tags main,promoted --by-version 42
 
   # Tag a specific Target by name
-  fioctl targets tag --tags main,testing intel-corei7-64-lmp-42`,
+  fioctl targets tag --tags master,testing intel-corei7-64-lmp-42`,
 		Run:  doTag,
 		Args: cobra.MinimumNArgs(1),
 	}

diff --git a/subcommands/version/cmd.go b/subcommands/version/cmd.go
@@ -38,7 +38,7 @@ func doVersion(cmd *cobra.Command, args []string) {
 		}
 		if err := update.Do(); err != nil {
 			if os.IsPermission(err) {
-				DieNotNil(fmt.Errorf("there was a permission error while updating Fioctl: %w. Please run again as an admin or root.", err))
+				DieNotNil(fmt.Errorf("There was a permission error while updating Fioctl: %w. Please run again as an admin or root.", err))
 			} else {
 				DieNotNil(err)
 			}

diff --git a/subcommands/version/update_self_windows.go b/subcommands/version/update_self_windows.go
@@ -27,7 +27,7 @@ func replaceSelf(curExe, newExe string) error {
 		return err
 	}
 	if err := os.Rename(newExe, curExe); err != nil {
-		msg := "unable to update to the new Fioctl binary. "
+		msg := "Unable to update to the new Fioctl binary. "
 		msg += "The old version is located at %s. "
 		msg += "The new version is located at %s. %w"
 		return fmt.Errorf(msg, oldExe, newExe, err)

diff --git a/subcommands/waves/cmd.go b/subcommands/waves/cmd.go
@@ -12,7 +12,7 @@ var api *client.Api
 var cmd = &cobra.Command{
 	Use:     "waves",
 	Aliases: []string{"wave"},
-	Short:   "Manage a Factory's Waves",
+	Short:   "Manage Factory Waves",
 	PersistentPreRun: func(cmd *cobra.Command, args []string) {
 		api = subcommands.Login(cmd)
 	},

diff --git a/subcommands/waves/status.go b/subcommands/waves/status.go
@@ -34,8 +34,8 @@ that belong to a given group and also have a tag equal to a group tag.
 This number can be lower than the total number of online devices in this group.
 
 In a device group overview, all Wave rollout groups are shown first in the order of rollout time.
-Next is other groups that have devices with a matching tag—if they contain at least one such device.
-The last row is for devices not belonging to any group—if at least one such device matches a Wave tag.
+Next is other groups that have devices with a matching tag — if they contain at least one such device.
+The last row is for devices not belonging to any group — if at least one such device matches a Wave tag.
 
 A number of updated devices depends onto a Wave status:
 For active Waves, it is a number of devices in rollout groups with Target version >= Wave version.