-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): make it so you can revert override of apps #440
feat(config): make it so you can revert override of apps #440
Conversation
Tangential note: we don't need to support |
7d7142f
to
854ec25
Compare
854ec25
to
fa5568e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically it looks good. Lets see what @kprosise says about the wording
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the latest changes seem to address feedback provided by other reviewers. Only suggestion has to do with style, but imho the descriptions communicate the usage well, neither too verbose or terse.
My 2 cents on the terms we use. IMHO, we should use the term "Compose apps" not "Docker apps" to make it consistent with the user doc. |
5436ba9
to
c3d393d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Once Katrina is happy, this can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided suggestions based upon feedback from @vkhoroz.
@StealthyCoder Is this PR ready for merging? |
Signed-off-by: Eric Bode <eric.bode@foundries.io>
c3d393d
to
e0b683e
Compare
This is to add a way to disable the override, inherit from parent concerning apps running on devices.
Relevant fioconfig code