Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): make it so you can revert override of apps #440

Merged

Conversation

StealthyCoder
Copy link
Member

This is to add a way to disable the override, inherit from parent concerning apps running on devices.

Relevant fioconfig code

@StealthyCoder StealthyCoder requested a review from doanac November 4, 2024 16:16
subcommands/config/updates.go Outdated Show resolved Hide resolved
subcommands/config/updates.go Outdated Show resolved Hide resolved
subcommands/devices/config_updates.go Outdated Show resolved Hide resolved
@mike-sul
Copy link
Contributor

mike-sul commented Nov 5, 2024

Tangential note: we don't need to support pacman.docker_apps not sure we've ever used it.
We deprecated it in v75 in this commit foundriesio/aktualizr-lite@34f8f70

@StealthyCoder StealthyCoder force-pushed the feat/restore_apps_override branch 2 times, most recently from 7d7142f to 854ec25 Compare November 5, 2024 10:22
@StealthyCoder StealthyCoder force-pushed the feat/restore_apps_override branch from 854ec25 to fa5568e Compare November 6, 2024 14:44
Copy link
Member

@doanac doanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically it looks good. Lets see what @kprosise says about the wording

@doanac doanac requested a review from kprosise November 6, 2024 17:21
Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the latest changes seem to address feedback provided by other reviewers. Only suggestion has to do with style, but imho the descriptions communicate the usage well, neither too verbose or terse.

subcommands/config/updates.go Outdated Show resolved Hide resolved
subcommands/config/updates.go Outdated Show resolved Hide resolved
subcommands/devices/config_updates.go Outdated Show resolved Hide resolved
subcommands/devices/config_updates.go Outdated Show resolved Hide resolved
@mike-sul
Copy link
Contributor

mike-sul commented Nov 7, 2024

My 2 cents on the terms we use. IMHO, we should use the term "Compose apps" not "Docker apps" to make it consistent with the user doc.

@StealthyCoder StealthyCoder force-pushed the feat/restore_apps_override branch 2 times, most recently from 5436ba9 to c3d393d Compare November 12, 2024 08:26
Copy link
Member

@vkhoroz vkhoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Once Katrina is happy, this can be merged.

subcommands/config/updates.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided suggestions based upon feedback from @vkhoroz.

subcommands/config/updates.go Outdated Show resolved Hide resolved
subcommands/config/updates.go Outdated Show resolved Hide resolved
subcommands/config/updates.go Outdated Show resolved Hide resolved
subcommands/devices/config_updates.go Outdated Show resolved Hide resolved
subcommands/devices/config_updates.go Outdated Show resolved Hide resolved
subcommands/devices/config_updates.go Outdated Show resolved Hide resolved
@mike-sul
Copy link
Contributor

@StealthyCoder Is this PR ready for merging?

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Signed-off-by: Eric Bode <eric.bode@foundries.io>
@StealthyCoder StealthyCoder force-pushed the feat/restore_apps_override branch from c3d393d to e0b683e Compare November 19, 2024 15:32
@StealthyCoder StealthyCoder merged commit 6086cc7 into foundriesio:main Nov 19, 2024
8 checks passed
@StealthyCoder StealthyCoder deleted the feat/restore_apps_override branch November 19, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants