feat: Alloy migration #2
Conversation
| use std::{fmt, str::FromStr}; | ||
|
|
||
| /// A block number or tag. | ||
| #[derive(Copy, Clone, Debug, Default, PartialEq, Eq, Hash)] |
There was a problem hiding this comment.
This eventually should come from RPC types.
There was a problem hiding this comment.
Flagging this also exists here: https://github.com/paradigmxyz/reth/blob/529635f8d4d627d3652807e3f0377b3c256de4fc/crates/primitives/src/block.rs#L548.
| }; | ||
|
|
||
| /// Helper type to parse numeric strings, `u64` and `U256` | ||
| #[derive(Deserialize, Debug, Clone)] |
There was a problem hiding this comment.
These were moved from ethers_core
There was a problem hiding this comment.
How do we do this in Reth? @mattsse
|
|
||
| /// Common Ethereum unit types. | ||
| #[derive(Clone, Copy, Debug, PartialEq, Eq, PartialOrd, Ord)] | ||
| pub enum Units { |
There was a problem hiding this comment.
Also moved from ethers_core. This feels like it should live somewhere else (maybe alloy), as a primitive.
There was a problem hiding this comment.
@prestwich @DaniPopes I am OK w/ moving this to core/ but no strong opinions
| use std::{fmt, str::FromStr}; | ||
|
|
||
| /// A block number or tag. | ||
| #[derive(Copy, Clone, Debug, Default, PartialEq, Eq, Hash)] |
There was a problem hiding this comment.
Flagging this also exists here: https://github.com/paradigmxyz/reth/blob/529635f8d4d627d3652807e3f0377b3c256de4fc/crates/primitives/src/block.rs#L548.
| }; | ||
| use alloy_json_abi::JsonAbi as Abi; | ||
| use alloy_primitives::{Address, Bytes}; | ||
| use ethers_core::abi::RawAbi; |
There was a problem hiding this comment.
This should be removed and adjusted to the right Alloy type, am OK w/ doing in follow up.
| }; | ||
|
|
||
| /// Helper type to parse numeric strings, `u64` and `U256` | ||
| #[derive(Deserialize, Debug, Clone)] |
There was a problem hiding this comment.
How do we do this in Reth? @mattsse
|
|
||
| /// Common Ethereum unit types. | ||
| #[derive(Clone, Copy, Debug, PartialEq, Eq, PartialOrd, Ord)] | ||
| pub enum Units { |
There was a problem hiding this comment.
@prestwich @DaniPopes I am OK w/ moving this to core/ but no strong opinions
| assert_eq!(item.abi().unwrap(), serde_json::from_str(DAO_ABI).unwrap()); | ||
| assert_eq!( | ||
| item.abi().unwrap(), | ||
| serde_json::from_str(DEPOSIT_CONTRACT_ABI).unwrap() |
There was a problem hiding this comment.
did anything not work with the DAO ABI?
Migrates the repo to alloy. The only remaining ethers types is
Chain, which is still being worked on as a separate package.