-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: align with new API res #66
base: main
Are you sure you want to change the base?
Conversation
/// data location | ||
pub data_reference: String, | ||
pub data_reference: Option<String>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these should have #[serde(default, skip_serializing_if = "Option::is_none")]
to actually make them optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed, thanks!
should we just remove the struct and
|
hmm i thought of keeping because it could be added back as same as it got removed (?) so it gets caught in that case-- blobscan API seems to not be versioned so far, so for that reason (as it existed, it may return, or not) But yeah happy to comment it out as well |
let's keep it then and add |
re-addressed! |
Update Blobscan API integration to match new schema
The Blobscan team has updated their API, removing
DataStorageReference
from thegetBlockById
method response. This PR aligns with new API schema at https://api.blobscan.com/#/blocks/block-getByBlockId :DataStorageReference
fields optional (Option)get_block_by_id
test with a mainnet block hash