Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP) feat(cheatcodes): add doc for cool #1006

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(WIP) feat(cheatcodes): add doc for cool #1006

wants to merge 1 commit into from

Conversation

ditto-eth
Copy link

@ditto-eth ditto-eth commented Sep 15, 2023 •
edited
Loading

Ref foundry-rs/foundry#5830
Ref foundry-rs/forge-std#456

don't merge yet since still wip (old docs), just wanted to share for initial feedback since might change the api a bit!

edit: other addition might be

struct StorageSlot {
  address target;
  bytes32 slot;
}
function cool(StorageSlot[] memory slots) external;

Evalir
Evalir requested changes Sep 15, 2023
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! The docs look good bar any API change we might make. Let's also add the page to SUMMARY.md or else it won't show up.

@Evalir
Copy link
Member

Evalir commented Oct 28, 2024

@onbjerg / @mattsse i assumed this can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ditto-eth @Evalir