Skip to content

chore: switch to Prague hardfork by default #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 28, 2025
Merged

chore: switch to Prague hardfork by default #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
898bcbb
switch to prague by default
zerosnacks May 21, 2025
9db6afb
bump solc version to prague compatible one
zerosnacks May 26, 2025
a63c27e
Merge branch 'main' into zerosnacks/add-prague-support
zerosnacks May 26, 2025
10fe5af
bump min solc version
zerosnacks May 26, 2025
928318c
Merge branch 'main' into zerosnacks/add-prague-support
zerosnacks May 28, 2025
3ac17c8
revert solc versions
zerosnacks May 28, 2025
8aa25cc
re-enforce minimum versions compatible with Prague >= 0.8.27
zerosnacks May 28, 2025
7c77b15
pin to 0.12.15 due to compilation bug: https://github.com/seanmonstar…
zerosnacks May 28, 2025
60e111d
unpin reqwest, 0.12.18 includes the fix
zerosnacks May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/artifacts/solc/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -793,7 +793,7 @@ impl YulDetails {

/// EVM versions.
///
/// Default is `Cancun`, since 0.8.25
/// Default is `Prague`, since 0.8.30
///
/// Kept in sync with: <https://github.com/ethereum/solidity/blob/develop/liblangutil/EVMVersion.h>
// When adding new EVM versions (see a previous attempt at https://github.com/foundry-rs/compilers/pull/51):
Expand All @@ -816,8 +816,8 @@ pub enum EvmVersion {
London,
Paris,
Shanghai,
#[default]
Cancun,
#[default]
Prague,
Osaka,
}
Expand Down
8 changes: 4 additions & 4 deletions crates/compilers/tests/project.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2678,7 +2678,7 @@ fn can_create_standard_json_input_with_external_file() {
]
);

let solc = Solc::find_or_install(&Version::new(0, 8, 24)).unwrap();
let solc = Solc::find_or_install(&Version::new(0, 8, 27)).unwrap();

// can compile using the created json
let compiler_errors = solc
Expand All @@ -2703,7 +2703,7 @@ fn can_compile_std_json_input() {
assert!(input.sources.contains_key(Path::new("lib/ds-test/src/test.sol")));

// should be installed
if let Ok(solc) = Solc::find_or_install(&Version::new(0, 8, 24)) {
if let Ok(solc) = Solc::find_or_install(&Version::new(0, 8, 28)) {
let out = solc.compile(&input).unwrap();
assert!(out.errors.is_empty());
assert!(out.sources.contains_key(Path::new("lib/ds-test/src/test.sol")));
Expand Down Expand Up @@ -2767,7 +2767,7 @@ fn can_create_standard_json_input_with_symlink() {
]
);

let solc = Solc::find_or_install(&Version::new(0, 8, 24)).unwrap();
let solc = Solc::find_or_install(&Version::new(0, 8, 28)).unwrap();

// can compile using the created json
let compiler_errors = solc
Expand Down Expand Up @@ -2936,7 +2936,7 @@ async fn can_install_solc_and_compile_std_json_input_async() {
tmp.assert_no_errors();
let source = tmp.list_source_files().into_iter().find(|p| p.ends_with("Dapp.t.sol")).unwrap();
let input = tmp.project().standard_json_input(&source).unwrap();
let solc = Solc::find_or_install(&Version::new(0, 8, 24)).unwrap();
let solc = Solc::find_or_install(&Version::new(0, 8, 27)).unwrap();

assert!(input.settings.remappings.contains(&"ds-test/=lib/ds-test/src/".parse().unwrap()));
let input: SolcInput = input.into();
Expand Down