fix: allow single sol file remappings #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xrusowsky
approved these changes
Aug 1, 2025
yash-atreya
approved these changes
Aug 1, 2025
2 tasks
DaniPopes
reviewed
Aug 1, 2025
| }); | ||
|
|
||
| if !s.ends_with('/') { | ||
| if !s.ends_with('/') && !s.ends_with(".sol") { |
There was a problem hiding this comment.
can we extract these conditions to a helper function?
mattsse
reviewed
Aug 1, 2025
There was a problem hiding this comment.
I see, that makes sense,
agree with @DaniPopes , we can make this a smol helper fn and ideally reference this pr in the fn docs
grandizzy
force-pushed
the
single-file-remapping
branch
from
df99349 to
49289cc
Compare
DaniPopes
approved these changes
Aug 1, 2025
0xrusowsky
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref foundry-rs/foundry#6706
tested and confirm solves foundry-rs/foundry#8499 too
/to remappings if single .sol file remapped - feat: allow single file remappings foundry#6706 (comment)stripped_importis empty then do not join when resolving library import as will append/- feat: allow single file remappings foundry#6706 (comment)forge remappingsproperly display remappings@ens/utils/BytesUtils.sol=src/BytesUtils.sol