Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: "expectEmit" cheatcode with no arguments #252

Closed
PaulRBerg opened this issue Dec 6, 2022 · 3 comments
Closed

Feature request: "expectEmit" cheatcode with no arguments #252

PaulRBerg opened this issue Dec 6, 2022 · 3 comments

Comments

@PaulRBerg
Copy link
Contributor

From the Foundry Book on best practices:

When testing events, prefer setting all expectEmit arguments to true, i.e. vm.expectEmit(true, true, true, true).

My feature request is to add an expectEmit cheatcode that has no arguments. All of the topics (checkTopic1, checkTopic2, checkTopic3, and checkData) would be set to true by default.
@ZeroEkkusu
Copy link
Collaborator

There was emission in #42.

@mds1
Copy link
Collaborator

mds1 commented Dec 7, 2022

This idea has been discussed / gotten support in the foundry telegram a few times, so per foundry-rs/foundry#3782 I'd support adding that cheat directly into foundry if you wanted to open the issue/PR there

@PaulRBerg PaulRBerg mentioned this issue Mar 3, 2023
Merged
@mds1
Copy link
Collaborator

mds1 commented Mar 9, 2023

Closed by #320

@mds1 mds1 closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PaulRBerg @mds1 @ZeroEkkusu