feat: add simple "expectEmit" #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wdyt of PR'ing this as a native cheat? It should be very simple to implement, and per foundry-rs/foundry#3782 it'd be ideal to start moving things there by default when we can |
Done!
I'm in favor of that proposal! |
PaulRBerg
force-pushed
the
expect-emit
branch
2 times, most recently
from
a7f427a to
2545bff
Compare
|
Since I ended up implementing this as a native cheat in Foundry (foundry-rs/foundry#4479), I refactored this branch to add the |
mds1
reviewed
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #252.
I know that this has been previously discussed in #42, but I think that this abstraction would be so helpful that it's worth reconsidering it.
FWIW: I have this function defined in like ~7 separate repos.