feat: implement boundInt

[JhChoy]

Implementing boundInt(int256,int256,int256) at StdUtils.sol to help fuzzing test with integer arguments.

One problem is that log(string,int256) does not exist so I used log(string,uint256) instead of it.

[mds1]

This is awesome, thanks a lot! Pinging @PaulRBerg since I know he was interesting in this method.

Just a few nits for you 🙂

[mds1]

(arbitrary comment location to start a thread)

One problem is that log(string,int256) does not exist so I used log(string,uint256) instead of it.

If you want to add support for this:

1. Add the required method to console2.sol in forge-std
2. Update the ABI file in foundry

I think that should be all that's needed, but I may be missing something. Also related is #129 if you wanted to add that overload at the same time

[JhChoy]

Okay, I'll check this out.

[JhChoy]

What will be the better one, log(string,int256) or logInt(string,int256)?
At the related thread of #129, they decided to name logInt(int256...) rather than log(int256...) because of the ambiguity.

[mds1]

I'm ok with log(string,int256) because in practice you'll be doing console.log(myVar) (unambiguous since myVar has a type) instead of console.log(3) (ambiguous because we don't know 3's type)

[JhChoy]

Applied at here!

[mds1]

Thanks! Note that the logs won't actually be shown until we upstream the corresponding change to forge. I can do that soon though

[PaulRBerg]

I don't currently have bandwidth to review but this is good stuff, thanks for implementing a signed bound, @JhChoy! I needed this for my PRBMath tests.

[mds1]

LGTM, thanks @JhChoy!

@ZeroEkkusu mind taking a look before we merge?

[mds1]

@JhChoy just a heads up I pushed two small commits to this branch and opened foundry-rs/foundry#3884

[JhChoy]

@mds1 Thanks for the review! 🙌

[ZeroEkkusu]

Thanks.

[ZeroEkkusu]

Pushed changes for 1.2.0 release.

After foundry-rs/foundry#3884 is resolved, we will remove the workaround.

Note: console2_log functions are part of the upcoming "remove Components" PR, so I made those changes here to avoid conflicts.

[ZeroEkkusu]

Thanks, @JhChoy - good work.