Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: provide pure bound int #350

Merged
merged 1 commit into from
Apr 18, 2023
Merged

refactor: provide pure bound int #350

merged 1 commit into from
Apr 18, 2023

Conversation

PaulRBerg
Copy link
Contributor

Addresses #349.

@PaulRBerg PaulRBerg mentioned this pull request Apr 17, 2023
Closed
@PaulRBerg PaulRBerg force-pushed the refactor/pure-bound-int branch from e92d95a to 625b8c3 Compare April 17, 2023 08:04
@PaulRBerg
Copy link
Contributor Author

CI tests have failed, but I think this is not related to my changes?

Test result: ok. 10 passed; 0 failed; finished in 1.60ms
2023-04-17T08:05:34.792106Z ERROR sharedbackend: Failed to send/recv `basic` err=GetAccount(0x1804c8ab1f12e6bbf3894d4083f33e07309d1f38, 
(code: -32000, message: unsupported block number 16747455, data: None)) address=0x1804c8ab1f12e6bbf3894d4083f33e07309d1f38

mds1
mds1 approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yep that test failure is just a flaky default RPC

@mds1 mds1 merged commit f06ad89 into foundry-rs:master Apr 18, 2023
@PaulRBerg PaulRBerg deleted the refactor/pure-bound-int branch April 18, 2023 12:07
@PaulRBerg PaulRBerg mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 mds1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulRBerg @mds1