Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed unnecessary todo comment #354

Merged
merged 1 commit into from
Apr 19, 2023
Merged

fix: removed unnecessary todo comment #354

merged 1 commit into from
Apr 19, 2023

Conversation

dd0sxx
Copy link
Contributor

@dd0sxx dd0sxx commented Apr 19, 2023

Discovered this todo comment in src/StdUtils.sol that seems out of place. Unless this is here for a reason, I suggest removing it.

@dd0sxx dd0sxx changed the title removed unnecessary todo comment fix: removed unnecessary todo comment Apr 19, 2023
mds1
mds1 approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mds1 mds1 merged commit 0492926 into foundry-rs:master Apr 19, 2023
@dd0sxx dd0sxx deleted the remove-todo branch April 19, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mds1 mds1 mds1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dd0sxx @mds1