perf: use staticcall instead of call #383
Conversation
| uint256 prevBal = abi.decode(balData, (uint256)); | ||
|
|
||
| // update balance | ||
| stdstore.target(token).sig(0x00fdd58e).with_key(to).with_key(id).checked_write(give); | ||
|
|
||
| // update total supply | ||
| if (adjust) { | ||
| (, bytes memory totSupData) = token.call(abi.encodeWithSelector(0xbd85b039, id)); | ||
| (, bytes memory totSupData) = token.staticcall(abi.encodeWithSelector(0xbd85b039, id)); |
There was a problem hiding this comment.
Overall this PR seems like it should be ok: ERC-20 requires that balanceOf and totalSupply are view methods, and ERC-1155 requires that balanceOf is view also
Interestingly I didn't see the totalSupply specified in 1155 though—@wirew0lf any idea on if using a staticcall for the 1155 methods here might be problematic for some reason?
There was a problem hiding this comment.
Hey! yeah I agree it's better to use staticcall, good call. About the ERC115 @mds1 ERC1155 doesn't have a total supply by default, it is an extension ERC1155Supply.
On the cheatcode I acocunted for this and revert if adjust is set to true but contract is no ERC115Supply with the message target contract is not ERC1155Supply. But yeah on ERC1155Supply totalSupply() is also a view function so no problem by using staticcall.
There was a problem hiding this comment.
Ah perfect, thanks @wirew0lf for the info and thanks @PaulRBerg for the PR!
Unless I'm missing something,
staticcallshould be used instead ofcallfor querying the token balances.Cc @brockelmore.