feat(vm): add keyExists
#423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
reviewed
Jul 18, 2023
src/Vm.sol
Outdated
Comment on lines
262
to
263
| // Checks if a key exists in a JSON or TOML object. | ||
| function keyExists(string calldata, string calldata) external view returns (bool); |
There was a problem hiding this comment.
We try to always used named inputs/outputs here for clarity, do you mind updating? (looks like the above parseJson* methods are also missing named params if you wanted to fix those also 😅
There was a problem hiding this comment.
oh yeah just followed what was above 😅 will update them all!
There was a problem hiding this comment.
hey @Evalir just bumping this
|
@mds1 should be g2g! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream from foundry-rs/foundry#5431