Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: new readme #424

Closed
wants to merge 3 commits into from
Closed

docs: new readme #424

wants to merge 3 commits into from

Conversation

ZeroEkkusu
Copy link
Collaborator

Motivation

Prettify and update readme.

Solution

Check out the new readme.


Note Any explanations you deem useful should be moved to the book.

@ZeroEkkusu ZeroEkkusu requested a review from mds1 July 19, 2023 17:45
@mds1
Copy link
Collaborator

mds1 commented Jul 19, 2023

It looks like a lot of info and sample code was removed, is this upstreamed to the book yet? We should hold off on merging until it's upstreamed somewhere, otherwise it will be harder for users to find / harder to point them to

@mds1
Copy link
Collaborator

mds1 commented Aug 30, 2023

I think it's useful to lean towards having too much information, so closing as stale for now, but happy to revisit an updated readme or reopen this when ready

@mds1 mds1 closed this Aug 30, 2023
@ZeroEkkusu
Copy link
Collaborator Author

The current readme still suffers from the two issues solved here:

  • The documentation in the book is out-of-date, and people aren't even aware that certain modules exist.
  • Even less modules are showcased in the readme, making no mention of the others, giving the impression that's all Forge Std has to offer.

I suggest the following:

If this readme looks good to you, a Read more button can be added next to the sections that have more information. These descriptions will live after everything in the readme, and on the click of the button, the readme will scroll down to the header with the current information. It will also have the ↩️ for quickly navigating back.

Let me know what you think.

@mds1
Copy link
Collaborator

mds1 commented Aug 31, 2023

Agreed that both the book documentation and forge-std README are missing a lot of information, and discoverability of things in forge-std has been a problem. Ideally we only need to maintain it in one place, which probably should be the book so everything users need is in one place.

I'm not sure I follow how your suggestion solves the issues since it contains less information than currently, but I do see two possible plans for solving those issues, cc @Evalir:

  1. First get the book updated to fully document forge-std, require book updates as part of PRs here going forward, then update the README to give a brief overview and link out to the book
  2. Given feat: move cheatcodes from forge-std to forge foundry#3782, gradually improve docs by first migrating things from forge-std to forge and documenting them in the book at that time. Once fully migrated upstream, then update the README/book accordingly with what's left in forge-std

@DaniPopes DaniPopes deleted the docs/readme branch October 24, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants