Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore inheritance order #425

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fix: restore inheritance order #425

merged 1 commit into from
Jul 19, 2023

Conversation

ZeroEkkusu
Copy link
Collaborator

Motivation

foundry-rs/foundry#5404

Solution

  • Remove warning note
  • Restore inheritance order

@ZeroEkkusu ZeroEkkusu requested a review from mds1 July 19, 2023 17:45
Copy link
Collaborator

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure unrelated, foundry-rs/foundry#5428 broke the ignore check which will be fixed upstream. Thanks!

@mds1 mds1 merged commit 75f1746 into master Jul 19, 2023
@DaniPopes DaniPopes deleted the fix/inheritance branch October 24, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants