chore: camelCase for exitCode #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, should have caught this when it was originally merged. This is technically a breaking change since it's already in a release, but the release was recent and from a sourcegraph query it seems vulcan are the only users (clearly that search isn't perfect since PRBTest isn't there). Given that, we can sneak this into a v1.7.0 once @vdrg and @gnkz from vulcan acknowledge |
|
@mds1 Thanks for letting us know! Acknowledged, we'll update forge-std once this is merged. |
|
Great, planning to merge+release early next week since I'm out this week—will keep you updated :) |
|
Also happy to update PRBTest to include the fix. I don't mind the breaking change since I've only added |
mds1
approved these changes
Sep 29, 2023
This was referenced Oct 2, 2023
gnkz
added a commit
to nomoixyz/vulcan
that referenced
this pull request
Oct 8, 2023
This is a breaking change because v.1.7.0 introduced a breaking change. Details here foundry-rs/forge-std#458
gnkz
added a commit
to nomoixyz/vulcan
that referenced
this pull request
Oct 8, 2023
* chore!: update forge-std to v1.7.1 This is a breaking change because v.1.7.0 introduced a breaking change. Details here foundry-rs/forge-std#458 * chore: remove ad-hoc SerializeJson interface * chore: update functions mutability
gnkz
added a commit
to nomoixyz/vulcan
that referenced
this pull request
Oct 8, 2023
* chore!: update forge-std to v1.7.1 This is a breaking change because v.1.7.0 introduced a breaking change. Details here foundry-rs/forge-std#458 * chore: remove ad-hoc SerializeJson interface * chore: update functions mutability
gnkz
added a commit
to nomoixyz/vulcan
that referenced
this pull request
Oct 10, 2023
* chore!: update forge-std to v1.7.1 This is a breaking change because v.1.7.0 introduced a breaking change. Details here foundry-rs/forge-std#458 * chore: remove ad-hoc SerializeJson interface * chore: update functions mutability
gnkz
added a commit
to nomoixyz/vulcan
that referenced
this pull request
Oct 10, 2023
* docs: add examples to some modules * Update forge-std (#214) * chore!: update forge-std to v1.7.1 This is a breaking change because v.1.7.0 introduced a breaking change. Details here foundry-rs/forge-std#458 * chore: remove ad-hoc SerializeJson interface * chore: update functions mutability * docs: add examples for all modules * style: format * docs: update installation instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pardon my OCD but I am getting a Solhint warning in my copy of
Vm(in PRBTest) because ofexit_code: