Codegen Vm.sol to mark envOr functions as view #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikaraghu
commented
Jan 11, 2024
src/StdChains.sol
Outdated
| @@ -148,7 +148,7 @@ abstract contract StdChains { | |||
|
|
|||
| // lookup rpcUrl, in descending order of priority: | |||
| // current -> config (foundry.toml) -> environment variable -> default | |||
| function getChainWithUpdatedRpcUrl(string memory chainAlias, Chain memory chain) private returns (Chain memory) { | |||
| function getChainWithUpdatedRpcUrl(string memory chainAlias, Chain memory chain) private view returns (Chain memory) { | |||
There was a problem hiding this comment.
fixing compiler warning (also same below in StdUtils.sol)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In foundry-rs/foundry#6757, we marked the
envOrfunctions as view functions. Updating equivalent function signatures hereCode diff is essentially the same as previous attempt #490, except this time I generated
Vm.solthe correct way by running thescripts/vm.pyscriptforge compileandforge teststill pass