fix: add missing console logs #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I copy pasted the console2 functions to console and replaced `int256` with `int`.
mds1
approved these changes
Jul 2, 2024
|
well, the thing is, it now compiles, but I am not sure if it actually prints anything. At least not with "forge 0.2.0 (5ac78a9 2024-06-02T00:19:17.377492500Z)" |
|
You're right, it's not hooked up, please open an issue in https://github.com/foundry-rs/foundry |
|
That's not idea, it could be a footgun, should it be rolled back, for now? I will report a bug or propose a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #573 (comment)
I copy pasted the console2 functions to console and replaced
int256withint.This is the entire diff.