-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add contribution guide and document scripts/vm.py
#618
Conversation
scripts/vm.py
To generate the changes from my PR on Foundry repo I had to manually modify vm.py to fetch the json from my repo+branch. It would be nice to be able to pass that information to vm.py, something like: $ ./scripts/vm.py tudmotu vm.mockCalls And it would fetch the json file from These params could be optional and default to "foundry-rs" and "master" respectively, to keep backwards-compatibility. WDYT? |
Ah I see, I generally wouldn't be against making this addition In terms of process it is usually the case that cheatcodes are first merged and then a follow-up PR in Would you like to contribute this change? |
Sure, will open a small PR using argparse and you can decide if you want to include it. Edit: #619 |
If the answer is not there: | ||
|
||
- Join the [support Telegram](https://t.me/foundry_support) to get help, or | ||
- Open a [discussion](https://github.com/foundry-rs/foundry/discussions/new) with your question, or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably should remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could still be useful as users generally don't know the distinction between Foundry
/ forge-std
Or are you in favor of deprecating either / any support portals? We haven't seen a lot of use of the Github discussions but it is a good place to find answers if we clean it up a bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be handled in a follow-up if desired cc @mds1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I mean the discussions.
Going to merge as it is relatively non-controversial and should help external contributors to run / update Happy to handle any follow-ups / modifications |
Copied from https://github.com/foundry-rs/foundry/blob/master/CONTRIBUTING.md with some minor modifications to make it specific to
forge-std
Documents running
vm.py
to updatesrc/Vm.sol
in more detail, related: #615 (comment) as well as the new--from
flag