Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: vm.getWallets() #620

Merged
merged 4 commits into from
Oct 15, 2024
Merged

feat: vm.getWallets() #620

merged 4 commits into from
Oct 15, 2024

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Oct 8, 2024

Companion PR for foundry-rs/foundry#9052

Adds the cheatcode function getWallets() external returns (address[] memory wallets)

@zerosnacks
Copy link
Member

Hey Yash, when adding cheatcodes make sure to run scripts/vm.py as documented here https://github.com/foundry-rs/forge-std/blob/master/CONTRIBUTING.md#adding-cheatcodes

It will automate the adding of the cheatcode in Vm.sol

@yash-atreya
Copy link
Member Author

yash-atreya commented Oct 14, 2024

Renamed to vm.getWallets() as per foundry-rs/foundry#9106

@yash-atreya yash-atreya changed the title feat: vm.getScriptWallets() feat: vm.getWallets() Oct 14, 2024
@yash-atreya yash-atreya marked this pull request as draft October 14, 2024 09:03
@yash-atreya
Copy link
Member Author

Merge after foundry-rs/foundry#9106

@yash-atreya yash-atreya marked this pull request as ready for review October 14, 2024 14:04
@yash-atreya yash-atreya merged commit 1de6eec into master Oct 15, 2024
3 checks passed
@DaniPopes DaniPopes deleted the yash/script-wallets branch October 24, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants