Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use alloy bindings #14

Merged
merged 3 commits into from
Jun 16, 2024
Merged

use alloy bindings #14

merged 3 commits into from
Jun 16, 2024

Conversation

yash-atreya
Copy link
Member

Migrate to alloy bindings after foundry-rs/foundry#7919

@yash-atreya
Copy link
Member Author

@DaniPopes I can fix the clippy issues by adding #[allow(clippy::all)], wdyt? Assuming these files should remain untouched by the user. It'll solve CI issues for all users with different clippy settings?

@DaniPopes
Copy link
Member

yes, that should be fine

@yash-atreya
Copy link
Member Author

CI will get fixed with nightly that includes foundry-rs/foundry#8171

@mattsse mattsse merged commit bcb18c9 into foundry-rs:master Jun 16, 2024
6 checks passed
@yash-atreya yash-atreya deleted the yash/mig_alloy branch June 16, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yash-atreya @DaniPopes @mattsse