Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(makefile): add a Makefile to help create bindings crate. #9

Merged
merged 9 commits into from
Nov 28, 2023
Merged

feat(makefile): add a Makefile to help create bindings crate. #9

merged 9 commits into from
Nov 28, 2023

Conversation

itsdevbear
Copy link
Contributor

No description provided.

@itsdevbear
Copy link
Contributor Author

@mattsse

mattsse
mattsse approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems fine.

lgtm

mattsse
mattsse requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you check the CI jobs, I think they need to be updated since we moved the bindings folder

@mattsse mattsse merged commit 645c092 into foundry-rs:master Nov 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsdevbear @mattsse